Re: [RFC][PATCH 3/7] cpufreq / sched: Check cpu_of(rq) in cpufreq_update_util()

From: Rafael J. Wysocki
Date: Mon Aug 01 2016 - 11:00:40 EST


On Monday, August 01, 2016 09:29:57 AM Dominik Brodowski wrote:
> A small nitpick:
>
> On Mon, Aug 01, 2016 at 01:36:01AM +0200, Rafael J. Wysocki wrote:
> > --- linux-pm.orig/kernel/sched/sched.h
> > +++ linux-pm/kernel/sched/sched.h
> > @@ -1760,7 +1760,7 @@ DECLARE_PER_CPU(struct update_util_data
> >
> > /**
> > * cpufreq_update_util - Take a note about CPU utilization changes.
> > - * @time: Current time.
> > + * @rq: Runqueue to carry out the update for.
> > *
> > * This function is called by the scheduler on every invocation of
> > * update_load_avg() on the CPU whose utilization is being updated.
>
> This comment seems to need an update due to the smp_processor_id() check
> being moved into this function.

Right.

Thanks,
Rafael