Re: [PATCH v2 0/6] extcon: Add the support for extcon type and property

[Guenter Roeck]

On Mon, Aug 1, 2016 at 6:52 PM, Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote:
> Hi Guenter,
>
> On 2016ë 08ì 02ì 03:18, Guenter Roeck wrote:
>> On Sun, Jul 31, 2016 at 10:50 PM, Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote:
>>> This patch-set add the support the extcon type, extcon property
>>> and the synchronization functions.
>>>
>>> The each external connector has the common characters. So, the external
>>> connectors are able to gather in the specific type. And the each external
>>> connectors has the specific H/W desigin to support the multiple features
>>> throught h/w lines. There are the requirement to express the each h/w
>>> character of each external connector. Lastly, when the state and property
>>> are changed, the extcon notify the extcon client driver of the changed
>>> information. To support the notification on extcon provider drivers,
>>> this patches support the three sync functions.
>>>
>>> Changes from v1:
>>> - Expand the size (+1) of the property array for each extcon type.
>>> - Use the memset() to initialize the property when connector is detached.
>>> - Wrap the data of struct extcon_dev in the lock mechanism.
>>> - Don't send the notification if connector state is not changed in
>>>   extcon_set_state_sync()
>>> - Fix the minor issue.
>>> - Add Tested-by tag of Chris Zhong for these patches.
>>> - Add Signed-off tag of Myungjoo Ham for patch1.
>>> - Add Reviewed-by tag of Guenter Roeck for patch6.
>>>
>>> Depends on:
>>> This patch depend on the extcon git repository[2]. (branch : extcon-next)
>>>
>>
>> For the series:
>>
>> Tested-by: Guenter Roeck <groeck@xxxxxxxxxxxx>
>
> Thanks for your test and review.
> I'll modify the minor issue of your comment. I'll send next version(v3) and then
> merged patches on extcon-next branch.
>

Sounds good.

Thanks,
Guenter