Re: [PATCH 0955/1285] Replace numeric parameter like 0444 with macro

From: Jes Sorensen
Date: Tue Aug 02 2016 - 08:57:39 EST


Baole Ni <baolex.ni@xxxxxxxxx> writes:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the
> corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx>
> Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx>
> ---
> drivers/staging/vt6656/main_usb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Excuse me, but why are you CC'ing everybody and their 217 cousins on
these patches?

The fact that someone had a patch applied in a directory close to this
file within the last 3 years is not justification for spamming them with
this.

Jes