RE: [PATCH 0807/1285] Replace numeric parameter like 0444 with macro

[Allen Hubbe]

From: Baole Ni
> diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.c b/drivers/ntb/hw/intel/ntb_hw_intel.c
> index 40d04ef..7aa1faa 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_intel.c
> +++ b/drivers/ntb/hw/intel/ntb_hw_intel.c
> @@ -92,56 +92,56 @@ static const struct file_operations intel_ntb_debugfs_info;
>  static struct dentry *debugfs_dir;
> 
>  static int b2b_mw_idx = -1;
> -module_param(b2b_mw_idx, int, 0644);
> +module_param(b2b_mw_idx, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);

The result of this change should be simplified to S_IWUSR | S_IRUGO.

>  module_param_named(xeon_b2b_usd_bar2_addr64,
> -		   xeon_b2b_usd_addr.bar2_addr64, ullong, 0644);
> +		   xeon_b2b_usd_addr.bar2_addr64, ullong, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);

This line is 97 columns long.

The result of this change should be simplified to S_IWUSR | S_IRUGO, and that might put it under 80 columns.  There are bound to still be other places where this kind of replacement will require additional changes to code formatting.