Re: [PATCH 0001/1285] Replace numeric parameter like 0444 with macro

[Masami Hiramatsu]

On Tue, 2 Aug 2016 14:15:03 +0100
One Thousand Gnomes <gnomes@xxxxxxxxxxxxxxxxxxx> wrote:

> On Tue,  2 Aug 2016 18:33:22 +0800
> Baole Ni <baolex.ni@xxxxxxxxx> wrote:
> 
> > I find that the developers often just specified the numeric value
> > when calling a macro which is defined with a parameter for access permission.
> > As we know, these numeric value for access permission have had the corresponding macro,
> > and that using macro can improve the robustness and readability of the code,
> > thus, I suggest replacing the numeric parameter with the macro.
> 
> If you are going to do this then please generate one patch per subsystem,
> and just do a couple of subsystems initially until everyone is happy with
> how it is being converted, then send out more subsystem by subsystem.

+1

Moreover, please DO NOT use same subject and same description for each patch (explain
what you did and why for each one), unless it will be just spamming git-log...

Thank you,


-- 
Masami Hiramatsu <mhiramat@xxxxxxxxxx>