Re: [GIT PULL] kbuild changes for v4.8-rc1
From: Michal Marek
Date: Tue Aug 02 2016 - 16:59:29 EST
Dne 2.8.2016 v 22:55 Kees Cook napsal(a):
> On Tue, Aug 2, 2016 at 1:41 PM, Linus Torvalds
> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>> On Tue, Aug 2, 2016 at 3:00 PM, Michal Marek <mmarek@xxxxxxxx> wrote:
>>>
>>> please merge these kbuild changes for v4.8-rc1:
>>
>> Merged. However, there were two slightly different versions of this
>> commit in my tree:
>>
>>> Kees Cook (2):
>>> kbuild: Abort build on bad stack protector flag
>>
>> differing by $ARCH vs $SRCARCH. There were a few other changes in that
>> area too, so I'd really like you to verify the end result.
>
> The version with $SRCARCH is the correct version. (I think akpm may
> have picked up the v1, but Michal requested some changes that resulted
> in the v2 with the $SRCARCH correction.)
Right, it should be $SRCARCH. But if you accidentally pushed the wrong
version, sky is not going to fall. It's just that make
ARCH=(i386|x86_64|um) will not do the compiler check, until a fix patch
is merged.
Michal