Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue

From: Michal Hocko
Date: Tue Aug 02 2016 - 17:35:12 EST


On Tue 02-08-16 15:02:44, Tejun Heo wrote:
> Hello,
>
> On Tue, Aug 02, 2016 at 03:29:48PM +0200, Oliver Neukum wrote:
> > Apparently if that is the requirement USB will have to define its own
> > set of flags to use in such contexts. But still the calls as currently
> > executed work. Taking away WQ_MEM_RECLAIM would create danger of
> > introducing a regression. The issue with __GFP_DIRECT_RECLAIM already
> > exists and can be fixed.
>
> Alright, let's go with WQ_MEM_RECLAIM then.

Agreed, I would just add
/*
* TODO: make sure that no work item in the rescuer can block on an
* allocation (so no __GF_DIRECT_RECLAIM)
*/
to all work item functions.
--
Michal Hocko
SUSE Labs