Re: [PATCH v2 2/2] spi: octeon: Add thunderx driver

From: David Daney
Date: Tue Aug 02 2016 - 18:07:47 EST


On 08/02/2016 02:30 PM, Mark Brown wrote:
On Mon, Aug 01, 2016 at 12:02:54PM -0700, David Daney wrote:
On 08/01/2016 11:49 AM, Mark Brown wrote:

What is that thing on ACPI systems?

I don't know if it works ACPI, or if ACPI even has support for the clock
framework. But does it matter? We are not currently using ACPI on systems
where this driver is used.

In the future, if we ever need ACPI support, we will add support for it.

Oh, that's surprising - I thought these were server systems.

There are two broad classes of systems targeted by Cavium's arm64 based SoCs:

1) 2-node NUMA servers with 96 CPUs running UEFI firmware and ACPI. For these, any SPI buses are managed by the firmware and we don't need Kernel support.

2) Embedded controllers with 4 - 32 CPUs, typically running u-boot and OF device tree firmware descriptions. For these configurations, SPI buses managed by the kernel must be supported.


With ACPI
you need to use DMI data or something to instantiate the clock. In any
case if you've got it working that should be OK.