Re: [PATCH v1 1/2] x86/power/64: Support unaligned addresses for temporary mapping

From: Thomas Garnier
Date: Wed Aug 03 2016 - 12:31:21 EST


On Tue, Aug 2, 2016 at 12:55 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> On Tue, Aug 2, 2016 at 10:48 AM, Thomas Garnier <thgarnie@xxxxxxxxxx> wrote:
>> On Tue, Aug 2, 2016 at 10:36 AM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>>>
>>> Looks like we need to change the loop from phys address to virtual
>>> address instead.
>>> to avoid the overflow.
>
> something like attached.

I tested it and it worked well. I just got this warning on build:

In file included from arch/x86/mm/init_64.c:60:0:
arch/x86/mm/ident_map.c: In function âident_pmd_initâ:
arch/x86/mm/ident_map.c:18:29: warning: suggest parentheses around
arithmetic in operand of â|â [-Wparentheses]
set_pmd(pmd, __pmd(vaddr - off | info->pmd_flag));

Do you want to resend your version for integration?