Re: [PATCH] shmem: Fix link error if huge pages support is disabled

[Kirill A. Shutemov]

On Wed, Aug 03, 2016 at 07:58:19PM +0200, Geert Uytterhoeven wrote:
> If CONFIG_TRANSPARENT_HUGE_PAGECACHE=n, HPAGE_PMD_NR evaluates to
> BUILD_BUG_ON(), and may cause (e.g. with gcc 4.12):
> 
>     mm/built-in.o: In function `shmem_alloc_hugepage':
>     shmem.c:(.text+0x17570): undefined reference to `__compiletime_assert_1365'
> 
> To fix this, move the assignment to hindex after the check for huge
> pages support.
> 
> Fixes: 800d8c63b2e989c2 ("shmem: add huge pages support")
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>

-- 
 Kirill A. Shutemov