Re: [PATCH v5 3/6] drm/i915/skl: Update plane watermarks atomically during plane updates

[Matt Roper]

On Wed, Aug 03, 2016 at 02:14:53PM -0700, Matt Roper wrote:
...
> 
> I imagine we'll eventually probably want to create a new display vfunc
> to handle platform-specific pipe-level stuff that needs to happen under
> vblank evasion (like the scalers and linetime WM we have today) to keep
> the code clean; maybe add a TODO comment to that effect?
> 
> Anyway, this looks good enough for now, so
> 
> Reviewed-by: Matt Roper <matthew.d.roper@xxxxxxxxx>

Woops, meant to add this reply to your v6 version of the patch
obviously...


Matt