Re: [PATCH 1/2] regmap: Add a function to check if a regmap register is cached

From: Mark Brown
Date: Thu Aug 04 2016 - 11:48:43 EST


On Thu, Aug 04, 2016 at 05:55:57PM +0300, Cristian Birsan wrote:

> +bool regmap_cached(struct regmap *map, unsigned int reg)
> +{
> + if (map->cache == REGCACHE_NONE)
> + return false;
> +
> + if (!map->cache_ops)
> + return false;
> +
> + if (map->max_register && reg > map->max_register)
> + return false;
> +
> + return true;
> +}

As Lars said this isn't actually checking if the register is cached. To
do this you need to modify the output code to check if there's a value
cached and try a read if there is one instead.

Attachment: signature.asc
Description: PGP signature