Re: [PATCH v2 13/44] x86/asm/head: remove useless zeroed word

From: Josh Poimboeuf
Date: Fri Aug 05 2016 - 12:23:14 EST


On Fri, Aug 05, 2016 at 12:13:04PM -0400, Brian Gerst wrote:
> On Thu, Aug 4, 2016 at 6:22 PM, Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> > This zeroed word has no apparent purpose, so remove it.
> >
> > Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> > ---
> > arch/x86/kernel/head_64.S | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/x86/kernel/head_64.S b/arch/x86/kernel/head_64.S
> > index 8822c20..ac6e27e 100644
> > --- a/arch/x86/kernel/head_64.S
> > +++ b/arch/x86/kernel/head_64.S
> > @@ -326,7 +326,6 @@ ENDPROC(start_cpu0)
> > .quad INIT_PER_CPU_VAR(irq_stack_union)
> > GLOBAL(initial_stack)
> > .quad init_thread_union+THREAD_SIZE-8
> > - .word 0
> > __FINITDATA
> >
> > bad_address:
>
>
> FYI the word used to be the SS segment selector for the LSS
> instruction, which isn't needed in 64-bit mode.

Thanks. I'll add that info to the patch header.

--
Josh