Re: [PATCH] scripts/Lindent: clean up and optimize

From: Jean Delvare
Date: Sun Aug 07 2016 - 11:49:52 EST


Hi Joe,

On Fri, 05 Aug 2016 10:53:19 -0700, Joe Perches wrote:
> On Fri, 2016-08-05 at 11:26 +0200, Jean Delvare wrote:
> > * Add a few blank lines to improve readability.
> > * Don't call cut 3 times when once is enough.
> > * Drop a useless semicolon.
>
> As it commonly reflows > 80 column code very badly,
> my preference would be to remove Lindent instead.
>
> https://lkml.org/lkml/2013/2/11/390

This was 3.5 years ago, so apparently it's not happening.

Why don't you just remove -l80 from the options, if this is your only
concern with the script? Adding the appropriate option to indent to
support what we think is good would seem even better, but I do not have
any time to devote to this task.

--
Jean Delvare
SUSE L3 Support