Re: [PATCH] power: reset: reboot mode: fix build error of missing ioremap/iounmap on UM

[Matthias Brugger]

On August 7, 2016 3:14:21 PM CEST, Andy Yan <andy.yan@xxxxxxxxxxxxxx> wrote:
>Add missing HAS_IOMEM dependency for MFD_SYSCON to fix the
>um-allyesconfig
>build error:
>
>drivers/mfd/syscon.c: In function 'of_syscon_register':
>drivers/mfd/syscon.c:67:9: error: implicit declaration of function
>'ioremap' [-Werror=implicit-function-declaration]
>  base = ioremap(res.start, resource_size(&res));
>         ^
>drivers/mfd/syscon.c:67:7: warning: assignment makes pointer from
>integer without a cast [-Wint-conversion]
>  base = ioremap(res.start, resource_size(&res));
>       ^
>drivers/mfd/syscon.c:109:2: error: implicit declaration of function
>'iounmap' [-Werror=implicit-function-declaration]
>  iounmap(base);
>  ^
>
>Signed-off-by: Andy Yan <andy.yan@xxxxxxxxxxxxxx>

Normally when sending a fix you specify:
commit sha ("commit subject")

regards,
Matthias

>---
>
> drivers/power/reset/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
>index 7053abc..1388be3 100644
>--- a/drivers/power/reset/Kconfig
>+++ b/drivers/power/reset/Kconfig
>@@ -190,6 +190,7 @@ config REBOOT_MODE
> config SYSCON_REBOOT_MODE
> 	tristate "Generic SYSCON regmap reboot mode driver"
> 	depends on OF
>+	depends on HAS_IOMEM
> 	select REBOOT_MODE
> 	select MFD_SYSCON
> 	help