Re: [PATCH] dmaengine: qcom_hidma: release the descriptor before the callback

[okaya]

On 2016-08-08 04:51, Vinod Koul wrote:
> > This patch is needed to fix a race condition as the commit message 
> > describes.
> > The callback is called before returning the descriptor back to free 
> > pool.
> >
> > If the client calls free resources, the descriptor that was not 
> > returned to free pool gets lost due
> > to race condition.
>
> Hmmm, if you have txn's pending and client wants to free up, shouldn't
> the pending txn's be cleaned up? Sound like a different bug to me..
>
> So if I submit 5 txn's and now want to freeup, will you still leak
> descriptors? Doesn't sound as right behaviour to me.

If free is called from the callback, current code will leak the current 
descriptor where free was called. It will release the other 4.

Because of ordering problem, descriptor is not in the active, pending or 
free pool.

I check pending txn by looking at active and queued lists when free is 
called.

After the callback, I put the descriptor back to free pool. At this 
moment, it is already too late.


> > I'll refactor the code after Dave's change for passing the error code 
> > while calling the
> > callback. That will be a different patch anyhow.
>
> Yes the error reporting is different