linux-4.8-rc1/drivers/scsi/sd.c:317: pointless test ?
From: David Binderman
Date: Mon Aug 08 2016 - 09:47:01 EST
Hello there,
linux-4.8-rc1/drivers/scsi/sd.c:317]: (style) Unsigned variable 'val'
can't be negative so it is unnecessary to test it.
Source code is
if (val >= 0 && val <= SD_DIF_TYPE3_PROTECTION)
but
unsigned int val;
Suggest new code
if (val <= SD_DIF_TYPE3_PROTECTION)
Regards
David Binderman