Re: [PATCH] x86/hweight: Don't clobber %rdi

[Borislav Petkov]

+ jikos.

On Mon, Aug 08, 2016 at 08:35:29PM +0300, ville.syrjala@xxxxxxxxxxxxxxx wrote:
> From: Ville SyrjÃlà <ville.syrjala@xxxxxxxxxxxxxxx>
> 
> The caller expects %rdi to remain intact, push+pop it make that happen.

Hmm, I've been staring at asm for the last hours and my head is spinning
now, so can you please point me at the exact where this happens. I can't
find it in x86_perf_event_update().

I'm guessing even though %rdi is callee-clobbered but since we're
spelling the asm for gcc, it can't know what happens to %rdi in order to
stash it away for the caller.

In any case, it is not a good idea to do the compiler's work. :-\

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--