Re: [PATCH] drm/cirrus: Fix NULL pointer dereference when registering the fbdev

[Boris Brezillon]

On Mon, 08 Aug 2016 22:36:13 -0500
ebiederm@xxxxxxxxxxxx (Eric W. Biederman) wrote:

> Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx> writes:
> 
> > cirrus_modeset_init() is initializing/registering the emulated fbdev
> > and, since commit c61b93fe51b1 ("drm/atomic: Fix remaining places where
> > !funcs->best_encoder is valid"), DRM internals can access/test some of
> > the fields in mode_config->funcs as part of the fbdev registration
> > process.
> > Make sure dev->mode_config.funcs is properly set to avoid dereferencing
> > a NULL pointer.  
> 
> That fixes the issues I am seeing.
> 
> Tested-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
> 
> > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> > Fixes: c61b93fe51b1 ("drm/atomic: Fix remaining places where !funcs->best_encoder is valid")
> > ---
> > Hi Dave,
> >
> > As discussed on IRC, I'm sending this patch in a proper format. That's
> > probably better to wait for Eric's feeback before applying it though.  
> 
> It is weird I didn't see either of your email messages directly only
> through lkml.  Weird.

Probably because of that

"
<ebiederm@xxxxxxxxxxxx>: host mx.xmission.com[166.70.12.20] said:
    550-XM-RJCT22: [37.187.137.238] is prohibited from connecting to
XMission mail 550-servers due to high spam volume. See the following
for more information: 550
    http://postmaster.xmission.com/senders/rbls.php?check_rbl=Submit&address=37.187.137.238
    (in reply to RCPT TO command)
"

I filled a form to add this IP to the xmission whitelist, let's see if
you receive my answer :).