Re: [PATCH] usb: ohci-platform: use helper variables in probe function

[Greg Kroah-Hartman]

On Fri, Jul 15, 2016 at 07:18:50AM +0200, RafaÅ MiÅecki wrote:
> Probing function was using &dev->dev and dev->dev.of_node over 20 times
> so I believe it made sense to use helper variables for both of them.
> To avoid some uncommon variable name for struct device I first replaced
> existing dev variable with pdev.
> 
> Signed-off-by: RafaÅ MiÅecki <zajec5@xxxxxxxxx>
> Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/usb/host/ohci-platform.c | 66 +++++++++++++++++++---------------------
>  1 file changed, 32 insertions(+), 34 deletions(-)

While "nice" this really isn't needed, unless you are going to do
something after this patch is applied.  And if so, please submit it as a
patch series.  As it is, it just looks like unneeded churn, sorry, so
I'm not going to take it.

thanks,

greg k-h