Re: [PATCH V2] usb: ehci-platform: use helper variables in probe function

From: Greg Kroah-Hartman
Date: Tue Aug 09 2016 - 10:00:04 EST


On Fri, Jul 15, 2016 at 07:05:56AM +0200, RafaÅ MiÅecki wrote:
> Probing function was using &dev->dev and dev->dev.of_node over 20 times
> so I believe it made sense to use helper variables for both of them.
> To avoid some uncommon variable name for struct device I first replaced
> existing dev variable with pdev.
>
> Signed-off-by: RafaÅ MiÅecki <zajec5@xxxxxxxxx>
> Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> ---
> V2: Use 2 extra tabs after line break to match one of already used
> coding styles.

Same comment here, unnecessary churn, sorry.

greg k-h