Re: [PATCH v2] x86/hweight: fix open-coded versions of 32bit and 64bit hweight calculations

From: Jiri Kosina
Date: Wed Aug 10 2016 - 14:33:53 EST


On Wed, 10 Aug 2016, Ingo Molnar wrote:

> > ENTRY(__sw_hweight64)
> > -#ifdef CONFIG_X86_64
> > +
>
> So this removes an #ifdef without removing the #else branch.

Hi Ingo,

this patch is obsolete; the real issue has already been fixed by 65ea11ec6
("x86/hweight: Don't clobber %rdi") in Linus' tree already.

Thanks,

--
Jiri Kosina
SUSE Labs