Re: [PATCH] IB/hfi1: Add missing error code assignment before test

[Dalessandro, Dennis]

On Wed, 2016-08-10 at 07:34 +0200, Christophe JAILLET wrote:
> It is likely that checking the result of 'setup_ctxt' is expected
> here.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> Âdrivers/infiniband/hw/hfi1/file_ops.c | 2 +-
> Â1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/hfi1/file_ops.c
> b/drivers/infiniband/hw/hfi1/file_ops.c
> index 1ecbec192358..ed76be39b20b 100644
> --- a/drivers/infiniband/hw/hfi1/file_ops.c
> +++ b/drivers/infiniband/hw/hfi1/file_ops.c
> @@ -222,7 +222,7 @@ static long hfi1_file_ioctl(struct file *fp,
> unsigned int cmd,
> Â		ret = assign_ctxt(fp, &uinfo);
> Â		if (ret < 0)
> Â			return ret;
> -		setup_ctxt(fp);
> +		ret = setup_ctxt(fp);
> Â		if (ret)
> Â			return ret;
> Â		ret = user_init(fp);

Thanks for the patch.

Acked-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx>