Re: [PATCH 1/4] dt-bindings: add doc for ibm,hotplug-aperture
From: Balbir Singh
Date: Thu Aug 11 2016 - 00:12:57 EST
On 09/08/16 04:27, Reza Arbab wrote:
> Signed-off-by: Reza Arbab <arbab@xxxxxxxxxxxxxxxxxx>
> ---
> .../bindings/powerpc/opal/hotplug-aperture.txt | 26 ++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/powerpc/opal/hotplug-aperture.txt
>
> diff --git a/Documentation/devicetree/bindings/powerpc/opal/hotplug-aperture.txt b/Documentation/devicetree/bindings/powerpc/opal/hotplug-aperture.txt
> new file mode 100644
> index 0000000..b8dffaa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/powerpc/opal/hotplug-aperture.txt
> @@ -0,0 +1,26 @@
> +Designated hotplug memory
> +-------------------------
> +
> +This binding describes a region of hotplug memory which is not present at boot,
> +allowing its eventual NUMA associativity to be prespecified.
> +
> +Required properties:
> +
> +- compatible
> + "ibm,hotplug-aperture"
> +
> +- reg
> + base address and size of the region (standard definition)
> +
> +- ibm,associativity
> + NUMA associativity (standard definition)
> +
> +Example:
> +
> +A 2 GiB aperture at 0x100000000, to be part of nid 3 when hotplugged:
> +
> + hotplug-memory@100000000 {
> + compatible = "ibm,hotplug-aperture";
> + reg = <0x0 0x100000000 0x0 0x80000000>;
> + ibm,associativity = <0x4 0x0 0x0 0x0 0x3>;
> + };
>
+Stewart and Alistair
Looks good to me!
Acked-by: Balbir Singh <bsingharora@xxxxxxxxx>