Re: [PATCH] powerpc: move hmi.c to arch/powerpc/kvm/

[Michael Ellerman]

Michael Ellerman <mpe@xxxxxxxxxxxxxx> writes:

> Radim KrÄmÃÅ <rkrcmar@xxxxxxxxxx> writes:
>
>> 2016-08-03 13:36+0200, Paolo Bonzini:
>>> hmi.c functions are unused unless sibling_subcore_state is nonzero, and
>>> that in turn happens only if KVM is in use.  So move the code to
>>> arch/powerpc/kvm/, putting it under CONFIG_KVM_BOOK3S_64_HANDLER
>>> rather than CONFIG_PPC_BOOK3S_64.  The sibling_subcore_state is also
>>> included in struct paca_struct only if KVM is supported by the kernel.
>>> 
>>> Cc: Paul Mackerras <paulus@xxxxxxxxx>
>>> Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
>>> Cc: Mahesh Salgaonkar <mahesh@xxxxxxxxxxxxxxxxxx>
>>> Cc: linuxppc-dev@xxxxxxxxxxxxxxxx
>>> Cc: kvm-ppc@xxxxxxxxxxxxxxx
>>> Cc: kvm@xxxxxxxxxxxxxxx
>>> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
>>> ---
>>> 	It would be nice to have this in 4.8, to minimize any 4.9 conflicts.
>>> 	Build-tested only, with and without KVM enabled.
>>
>> If you agree with the change, would you prefer to have this patch merged
>> through the PowerPC tree?
>
> Yeah I'll pull it into my fixes branch.

And then I pulled it out again:

  (.text+0x157fc): undefined reference to `.wait_for_subcore_guest_exit'
  (.text+0x15834): undefined reference to `.wait_for_tb_resync'
  make[1]: *** [vmlinux] Error 1

http://kisskb.ellerman.id.au/kisskb/buildresult/12775422/

cheers