Re: [PATCH 00/13] various remoteproc/rpmsg trivial cleanups

From: Bjorn Andersson
Date: Sat Aug 13 2016 - 01:16:09 EST


On Fri 12 Aug 16:42 PDT 2016, Suman Anna wrote:

> Hi Bjorn,
>
> Following are a bunch of trivial cleanups in remoteproc core, rpmsg
> bus core and couple of cleanups in OMAP remoteproc driver. The patches
> are baselined on 4.8-rc1 + your rproc-next branch.
>
> The only non-cleanup patches are the last two patches - the first of
> which switches a hex_dump to a dynamic hex dump, and the second one is
> a fix to rpmsg client sample to scale for multiple instances when you
> have more than one remoteproc publishing the same rpmsg channel.
>
> regards
> Suman
>

Thanks,

Related to the hexdump stuff; I've seen (and used) a few different
patches for getting dumps out and converted to pcap format for analysis
in Wireshark. I think this would be a really nice feature to have
available without 3rd party patches.

> Suman Anna (13):
> remoteproc: use proper format-specifier for printing dma_addr_t
> remoteproc: fix couple of minor typos
> remoteproc: use variable names for sizeof() operator
> remoteproc: fix bare unsigned type usage
> remoteproc: align code with open parenthesis
> remoteproc: print hex numbers with a leading 0x format
> remoteproc/omap: fix various code formatting issues
> remoteproc/omap: revise a minor error trace message

Applied to rproc-next

> rpmsg: remove pointless OOM prints
> rpmsg: use proper format-specifier for printing dma_addr_t
> rpmsg: align code with open parenthesis
> rpmsg: use dynamic_hex_dump for hex dump traces
> samples/rpmsg: add support for multiple instances

Applied to rpmsg-next

Regards,
Bjorn