Re: [PATCH] helene: fix memory leak when heleno_x_pon fails

[Abylay Ospan]

Hi Colin,

It's really possible memory leak here. thanks for fix.

Acked-by: Abylay Ospan <aospan@xxxxxxxx>

2016-08-13 14:16 GMT-04:00 Colin King <colin.king@xxxxxxxxxxxxx>:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The error return path of failed calls to heleno_x_pon leak
> memory because priv is not kfree'd.  Fix this by kfree'ing
> priv before returning.
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
>  drivers/media/dvb-frontends/helene.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/dvb-frontends/helene.c b/drivers/media/dvb-frontends/helene.c
> index 97a8982..3d1cd5f 100644
> --- a/drivers/media/dvb-frontends/helene.c
> +++ b/drivers/media/dvb-frontends/helene.c
> @@ -987,8 +987,10 @@ struct dvb_frontend *helene_attach_s(struct dvb_frontend *fe,
>         if (fe->ops.i2c_gate_ctrl)
>                 fe->ops.i2c_gate_ctrl(fe, 1);
>
> -       if (helene_x_pon(priv) != 0)
> +       if (helene_x_pon(priv) != 0) {
> +               kfree(priv);
>                 return NULL;
> +       }
>
>         if (fe->ops.i2c_gate_ctrl)
>                 fe->ops.i2c_gate_ctrl(fe, 0);
> @@ -1021,8 +1023,10 @@ struct dvb_frontend *helene_attach(struct dvb_frontend *fe,
>         if (fe->ops.i2c_gate_ctrl)
>                 fe->ops.i2c_gate_ctrl(fe, 1);
>
> -       if (helene_x_pon(priv) != 0)
> +       if (helene_x_pon(priv) != 0) {
> +               kfree(priv);
>                 return NULL;
> +       }
>
>         if (fe->ops.i2c_gate_ctrl)
>                 fe->ops.i2c_gate_ctrl(fe, 0);
> --
> 2.8.1
>



-- 
Abylay Ospan,
NetUP Inc.
http://www.netup.tv