Re: [PATCH 0/2] be2iscsi: Logging neatening
From: Joe Perches
Date: Sun Aug 14 2016 - 13:30:44 EST
On Sun, 2016-08-14 at 17:09 +0000, Bart Van Assche wrote:
> My primary concern is how to enable and disable log messages from user
> space. Many drivers define their own logging macros and export a bitmask
> that allows to enable and disable logging messages per category. These
> bitmask control mechanisms are annoying because figuring out what bit
> controls which message category requires a search through the driver
> source code. I'd like to see all these custom logging macros disappear
> and being replaced by a single mechanism. The "dynamic debug" mechanism
> e.g. is in my opinion much easier to use than the different custom
> logging mechanisms.
Dynamic debug doesn't have a bitmask function and
still requires looking through the code for lines
and format strings.
I think you are looking for a system wide equivalent
for the ethtool/netif_<level> mechanism.
Nothing like that exists currently.
Some code uses a bitmask/and, other code uses a
level/comparison.
Care to propose something?