Re: [PATCH] block: Fix secure erase
From: Christoph Hellwig
Date: Mon Aug 15 2016 - 14:15:05 EST
On Mon, Aug 15, 2016 at 11:43:12AM -0500, Shaun Tancheff wrote:
> Hmm ... Since REQ_SECURE implied REQ_DISCARD doesn't this
> mean that we should include REQ_OP_SECURE_ERASE checking
> wherever REQ_OP_DISCARD is being checked now in drivers/scsi/sd.c ?
>
> (It's only in 3 spots so it's a quickie patch)
SCSI doesn't support secure erase operations. Only MMC really
supports it, plus the usual cargo culting in Xen blkfront that's
probably never been tested..