Re: [BUGFIX PATCH 1/2] brcmfmac: Check rtnl_lock is locked when removing interface

[Arend Van Spriel]

On 15-8-2016 13:52, RafaÅ MiÅecki wrote:
> On 15 August 2016 at 12:57, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote:
>> RafaÅ MiÅecki <zajec5@xxxxxxxxx> writes:
>>
>>>> Signed-off-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
>>>
>>> Fixes: a63b09872c1d ("brcmfmac: delete interface directly in code that sent fw request")
>>> Acked-by: RafaÅ MiÅecki <rafal@xxxxxxxxxx>
>>>
>>> Kalle: I'm acking this as bugfix for 4.8 release.
>>
>> Ok. I'll wait few days for more comments before I apply this.
> 
> Sure.
> 
> 
>> (I assume you are talking only about patch 1)
> 
> Yes, I'll leave mutex vs. spinlock to the experts :)

Don't know who the experts are. Surely not me :-p

I made an uneducated design decision using a mutex for this. The
reasoning for using a regular spinlock make sense. So I will go and ack
that patch.

Regards,
Arend