Re: [PATCH] nvme-rdma: initialize ret to zero to avoid returning garbage

[Sagi Grimberg]

On 16/08/16 11:24, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> ret is not initialized so it contains garbage.  Ensure garbage
> is not returned by initializing rc to 0.
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
>  drivers/nvme/host/rdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index 8d2875b..9c69393 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -1319,7 +1319,7 @@ out_destroy_queue_ib:
>  static int nvme_rdma_device_unplug(struct nvme_rdma_queue *queue)
>  {
>  	struct nvme_rdma_ctrl *ctrl = queue->ctrl;
> -	int ret;
> +	int ret = 0;
>
>  	/* Own the controller deletion */
>  	if (!nvme_change_ctrl_state(&ctrl->ctrl, NVME_CTRL_DELETING))

Applied for the next round of rc fixes.

Thanks Colin.