Re: [PATCH v0 4/4] i2c: meson: Use complete() instead of complete_all()

From: Kevin Hilman
Date: Tue Aug 16 2016 - 09:12:55 EST


Daniel Wagner <wagi@xxxxxxxxx> writes:

> From: Daniel Wagner <daniel.wagner@xxxxxxxxxxxx>
>
> There is only one waiter for the completion, therefore there
> is no need to use complete_all(). Let's make that clear by
> using complete() instead of complete_all().
>
> The usage pattern of the completion is:
>
> meson_i2c_xfer_msg()
> reinit_completion()
> ...
> /* Start the transfer */
> ...
> wait_for_completion_timeout()
>
> Signed-off-by: Daniel Wagner <daniel.wagner@xxxxxxxxxxxx>

Acked-by: Kevin Hilman <khilman@xxxxxxxxxxxx>