Re: RFC: callchain showing same entry as hist_entry
From: Namhyung Kim
Date: Tue Aug 16 2016 - 11:48:43 EST
On Tue, Aug 16, 2016 at 12:32:44PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Aug 16, 2016 at 12:31:43PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Wed, Aug 17, 2016 at 12:23:55AM +0900, Namhyung Kim escreveu:
> > > Did you run 'perf report -s sym --stdio'? It seems that current code
> > > already works as sane.. Do you want to make it work for the default sort
> > >> key too?
> >
> > What I want is not to repeat the hist_entry line as the first entry in
> > the callchain, which is confusing.
> >
> > I.e. repeat the duplication that is happening with the default sort
>
> s/repeat/remove/g
>
> > entry, that contains "sym".
Hmm.. if so, wouldn't it be better skipping the first callchain entry
when the user-given sort key contains "sym" too (not only when it
starts with 'sym')?
Thanks,
Namhyung