Re: [tip:x86/boot] x86/mm: Enable KASLR for physical mapping memory regions

From: Brian Gerst
Date: Tue Aug 16 2016 - 20:31:34 EST


On Tue, Aug 16, 2016 at 5:01 PM, Borislav Petkov <bp@xxxxxxxxx> wrote:
> On Tue, Aug 16, 2016 at 12:49:52PM -0700, Kees Cook wrote:
>> Am I misreading this?
>
> No you're not.
>
>> Shouldn't it be:
>>
>> cont = container;
>> #ifdef CONFIG_RANDOMIZE_MEMORY
>> cont += PAGE_OFFSET - __PAGE_OFFSET_BASE;
>> #endif
>>
>> (otherwise cont is undefined in the RANDOMIZE_MEMORY=n case?)
>
> Thanks for catching this Kees, I'll send a new version in the morning.

These fixes work for my system.

--
Brian Gerst