Re: [PATCH v5] spi: spi-ti-qspi: Add DMA support for QSPI mmap read

From: Vignesh R
Date: Wed Aug 17 2016 - 01:13:32 EST




On Wednesday 17 August 2016 12:12 AM, Mark Brown wrote:
> On Tue, Aug 09, 2016 at 06:20:01PM +0530, Vignesh R wrote:
>>
>>
>
>> According to this thread[1], converting virtual address
>> pointer into scatterlist which is then DMA mapped is unsafe on systems
>> with certain cache architecture. Hence, I added code to handle kmap
>> buffers inside the driver rather than updating generic spi-core code.
>
> That's saying that things that aren't covered aren't DMAable safely at
> all which is a more general issue...
>
>> If its okay to update the spi_map_buf() to handle kmap buffers as above
>> then I can submit the patch accordingly.
>
> Yes, the whole point is that this is all in generic code so drivers
> don't need to worry about it.

Ok, I will send another version updating spi_map_buf() to handle kmap
buffers. Thanks!

--
Regards
Vignesh