Re: [PATCH 2/2] ARM: davinci_all_defconfig: enable modules for sound on LCDK
From: Karl Beldan
Date: Wed Aug 17 2016 - 06:12:52 EST
On Wed, Aug 17, 2016 at 02:20:51PM +0530, Sekhar Nori wrote:
> On Thursday 11 August 2016 01:38 AM, Karl Beldan wrote:
> > This is the minimal set of additional modules required to support audio
> > on the LCDK.
> >
> > Signed-off-by: Karl Beldan <kbeldan@xxxxxxxxxxxx>
>
> This patch does not apply because Kevin already added some missing audio
> modules through commit "ARM: davinci_all_defconfig: enable DA850 audio
> as modules"
>
> Can you please rebase on master branch of my tree[1] and resend?
>
I checked out your tree.
With Kevin's patch the needed modules get selected without needing 2/2.
However I don't know why he used:
CONFIG_SND_DA850_SOC_EVM=m
instead of:
CONFIG_SND_DAVINCI_SOC_MCASP=m
CONFIG_SND_SOC_TLV320AIC3X=m
The former seems to me to be pre-DT style config. I used the latter in
2/2 and thought that's what we'd start switching to ? Unless it is for
pre-DT compatibility ?
Karl