Re: [PATCH] ARM: dts: exynos: Use stdout non-deprecated property and add serial options to Odroid XU/XU3/XU4

[Mark Rutland]

On Wed, Aug 17, 2016 at 12:28:48PM +0200, Krzysztof Kozlowski wrote:
> On 08/17/2016 12:25 PM, Mark Rutland wrote:
> > On Wed, Aug 17, 2016 at 09:34:58AM +0200, Krzysztof Kozlowski wrote:
> >> The "linux,stdout-path" is deprecated.
> >>
> >> Add serial options so the console can be properly configured when
> >> bootloader does not pass "console" parameter to command line.  Without
> >> options and lack of "console", the serial output dies during boot (just
> >> after probing sound).
> > 
> > I'm confused. Is this just a cleanup (given "linux,stdout-path" is
> > deprecated but still supported), or a bug fix?
> 
> There is no bug, so rather this is cleanup and improvement in one.
> Usually we pass full console=ttySAC2,115200n8 from UBoot to command
> line. The usage of serial options allows skipping that.
> 
> I can split the cleanup part from improvement. To me it looked a little
> bit too much but I don't mind.

No need. It just wasn't clear to me that you had U-Boot configured to
pass the rate on the command line.

As I mentioned, I suspect that the serial output doesn't "die" as such,
but rather changes rate. It might be worth clarifying that in the commit
message, but either way the patch itself is fine, and it's no big deal.

Thanks,
Mark.