Re: [PATCH v9 4/4] arm64: dts: rockchip: configure usb2-phy support for rk3399-evb

[Frank Wang]

On 2016/8/17 18:02, Heiko Stübner wrote:
> Am Freitag, 22. Juli 2016, 15:00:46 schrieb Frank Wang:
> > Add vcc5v0_host regulator for usb2-phy and enable host-port support.
> >
> > Signed-off-by: Frank Wang <frank.wang@xxxxxxxxxxxxxx>
> applied to ny dts64 branch [0] with some changes:
>
> - the pin is named vcc5v0_host_en not host_vbus_drv in the schematics
>    please always try to use the names from the schematics
> - separated the enablement of the subnodes

Thanks for your valuable comments, I will try to improve the quality of 
my patches in future.

BR.
Frank

> Heiko
>
> [0] https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?id=1d3bc1d6c9c4658d554bcf89a71b35a6783a5b4e
>
>
> > ---
> >   arch/arm64/boot/dts/rockchip/rk3399-evb.dts |   44
> > +++++++++++++++++++++++++++ 1 file changed, 44 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
> > b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts index 1a3eb14..56aeedb 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
> > @@ -69,6 +69,25 @@
> >   		regulator-max-microvolt = <3300000>;
> >   	};
> >
> > +	vcc5v0_sys: vcc5v0-sys {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "vcc5v0_sys";
> > +		regulator-always-on;
> > +		regulator-boot-on;
> > +		regulator-min-microvolt = <5000000>;
> > +		regulator-max-microvolt = <5000000>;
> > +	};
> > +
> > +	vcc5v0_host: vcc5v0-host-regulator {
> > +		compatible = "regulator-fixed";
> > +		enable-active-high;
> > +		gpio = <&gpio4 25 GPIO_ACTIVE_HIGH>;
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&host_vbus_drv>;
> > +		regulator-name = "vcc5v0_host";
> > +		vin-supply = <&vcc5v0_sys>;
> > +	};
> > +
> >   	vcc_phy: vcc-phy-regulator {
> >   		compatible = "regulator-fixed";
> >   		regulator-name = "vcc_phy";
> > @@ -89,6 +108,24 @@
> >   	status = "okay";
> >   };
> >
> > +&u2phy0 {
> > +	status = "okay";
> > +
> > +	u2phy0_host: host-port {
> > +		phy-supply = <&vcc5v0_host>;
> > +		status = "okay";
> > +	};
> > +};
> > +
> > +&u2phy1 {
> > +	status = "okay";
> > +
> > +	u2phy1_host: host-port {
> > +		phy-supply = <&vcc5v0_host>;
> > +		status = "okay";
> > +	};
> > +};
> > +
> >   &uart2 {
> >   	status = "okay";
> >   };
> > @@ -121,4 +158,11 @@
> >   				<1 18 RK_FUNC_GPIO &pcfg_pull_down>;
> >   		};
> >   	};
> > +
> > +	usb2 {
> > +		host_vbus_drv: host-vbus-drv {
> > +			rockchip,pins =
> > +				<4 25 RK_FUNC_GPIO &pcfg_pull_none>;
> > +		};
> > +	};
> >   };