Re: [PATCH 1/2] x86/smpboot: Check APIC ID before setting up default routing

[Ingo Molnar]

* Wei Jiangang <weijg.fnst@xxxxxxxxxxxxxx> wrote:

> Check the boot APIC ID firstly,
> and then setup the default routing of APIC looks better.
> 
> And move default_setup_apic_routing() close to apic_bsp_setup(),
> which staying in step with the codes in APIC_init_uniprocessor().
> 
> Signed-off-by: Wei Jiangang <weijg.fnst@xxxxxxxxxxxxxx>
> ---
>  arch/x86/kernel/smpboot.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

If it's not a bug then please clearly note so in the changelog and
explain why the change results in better code.

If it's fixing a bug/misfeature then please fix the changelog to
conform to the standard changelog style:

 - first describe the symptoms of the bug - how does a user notice? 

 - then describe how the code behaves today and how that is causing the bug

 - and then only describe how it's fixed.

Thanks,

        Ingo