Re: [PATCH for 4.8] ASoC: omap-abe-twl6040: Correct dmic-codec device registration

From: Russell King - ARM Linux
Date: Fri Aug 19 2016 - 04:54:27 EST


On Fri, Aug 19, 2016 at 09:34:24AM +0300, Peter Ujfalusi wrote:
> The dmic-codec was registered within the platform_driver's probe function,
> which can cause deferred probe to run in loops as reported and analyzed by
> Russell King.
>
> Use module_init/exit in the driver and handle the dmic-codec device
> registration and removal at that level instead of the platform_driver
> probe/remove.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
> Reported-by: Russell King <linux@xxxxxxxxxxxxxxxx>

I think this address came from memory... it's certainly not the one that
I'm using today. ;)

> ---

This certainly fixes the problem:

VUSB: disabling
mmcblk0: mmc0:0002 00000 972 MiB
ALSA device list:
mmcblk0: p1 p2
No soundcards found.
omap-abe-twl6040 sound: ASoC: CPU DAI (null) not registered
omap-abe-twl6040 sound: snd_soc_register_card() failed: -517
Waiting 2 sec before mounting root device...
EXT4-fs (mmcblk0p2): mounting ext3 file system using the ext4 subsystem
EXT4-fs (mmcblk0p2): warning: maximal mount count reached, running e2fsck is recommended

and allows booting to continue. Thanks.

Tested-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>

--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.