Re: [RFC PATCH] arm64/hugetlb enable gigantic hugepage

[Michal Hocko]

On Thu 18-08-16 20:05:29, Xie Yisheng wrote:
> As we know, arm64 also support gigantic hugepage eg. 1G.

Well, I do not know that. How can I check?

Anyway to the patch
[...]
> index 87e11d8..b4d8048 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1022,7 +1022,8 @@ static int hstate_next_node_to_free(struct hstate *h, nodemask_t *nodes_allowed)
>  		((node = hstate_next_node_to_free(hs, mask)) || 1);	\
>  		nr_nodes--)
>  
> -#if (defined(CONFIG_X86_64) || defined(CONFIG_S390)) && \
> +#if (defined(CONFIG_X86_64) || defined(CONFIG_S390) || \
> +	defined(CONFIG_ARM64)) && \
>  	((defined(CONFIG_MEMORY_ISOLATION) && defined(CONFIG_COMPACTION)) || \
>  	defined(CONFIG_CMA))

this ifdef is getting pretty unwieldy. For one thing I think that
respective archs should enable ARCH_HAVE_GIGANTIC_PAGES.

>  static void destroy_compound_gigantic_page(struct page *page,
> -- 
> 1.7.12.4
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>

-- 
Michal Hocko
SUSE Labs