Re: [PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from <linux/types.h>"

[Marek OlÅÃk]

On Fri, Aug 19, 2016 at 4:52 PM, Mikko Rapeli <mikko.rapeli@xxxxxx> wrote:
> On Fri, Aug 19, 2016 at 04:26:40PM +0200, Christian KÃnig wrote:
>> Am 19.08.2016 um 15:50 schrieb Marek OlÅÃk:
>> >From: Marek OlÅÃk <marek.olsak@xxxxxxx>
>> >
>> >This reverts commit 2ce9dde0d47f2f94ab25c73a30596a7328bcdf1f.
>> >
>> >See the comment in the code. Basically, don't do cleanups in this header.
>> >
>> >Signed-off-by: Marek OlÅÃk <marek.olsak@xxxxxxx>
>>
>> I completely agree with you that this was a bad move, but I fear that we
>> will run into opposition with that.
>>
>> Adding Mikko Rapeli who made the reverted patch to comment.
>
> But this header is part of Linux kernel uapi. Remove it from there too then.

That's a good idea, but it really is a uapi header in the sense that
it defines the kernel driver interface for a specific kernel version.
However, it is not a header that the userspace stack should include,
because userspace should get it from libdrm. (it makes userspace more
independent from the currently running kernel)

Marek