Re: [PATCH 6/6] Add dockerfile

From: Theodore Ts'o
Date: Sun Aug 21 2016 - 11:36:05 EST


On Sun, Aug 21, 2016 at 03:02:38PM +0300, Dmitry Monakhov wrote:
> Probably it it reasonable to create dedicated directory ./docker
> and place all docker related crap there:
> # build scripts
> docker/Dockerfile.build-env
> docker/Dockerfile.run-env
> # And some run scripts
> # Build all environment from scratch
> docker/docker-build.sh
> # Move config, kernel, root_fs.img inside container and run {gce,kvm}-xfstests.sh
> docker/docker-kvm-xfstests.sh
> docker/docker-gce-xfstests.sh

I thought about that, but my current thinking is to have one
Dockerfile which is in the top-level directory, and one which is in
the kvm-xfstests directory.

I've already created a tytso/xfststs-bld Docker image which was
generated using:

docker build -t tytso/xfstests-bld https://github.com/tytso/xfstests-bld.git

By putting the Dockerfile in the top-level directory, I can use the
command "COPY . /devel/xfstests-bld" in the Dockerfile, and so we can
get a clean build build that way.

By putting a Dockerfile in the kvm-xfstests directory, then all I have
to do is to put a "COPY . /usr/local/lib/kvm-xfstests" which will copy
all of the kvm-xfstests directory directly where we want the files in
the kvm-xfstests Docker image. I'm assuming that my release process
will first build root_fs.i386 and root_fs.x86_64 using debian chroots,
and then upload them to www.kernel.org. I'll then run:

docker build -t tytso/kvm-xfstests https://github.com/tytso/xfstests-bld.git:kvm-xfstests

... and then the Dockerfile will pull the root_fs.i386 from
ftp.kernel.org.

What do you think?

- Ted