Re: [PATCH] staging: comedi: dt2811: add parentheses to fix logic on s->subdev_flags

[Greg Kroah-Hartman]

On Mon, Jul 25, 2016 at 11:25:25PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> We need to add parentheses around ternary operations because currently
> the expression SDF_READABLE | (it->options[2] == 1) always evaluates to
> true, meaning s->subdev_flags is always assigned SDF_DIFF. Putting the
> parentheses around the ternarary operations results in the intended
> expression of SDF_REABLE logically or'd with one of SDF_DIFF,
> SDF_COMMON or SDF_GROUND.
> 
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> Fixes: 7c9574090d30 ("staging: comedi: dt2811: simplify A/D reference configuration")
> Cc: <stable@xxxxxxxxxxxxxxx> # 4.7+
> Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>


Dan sent a patch for this before you did :(

And this went into 4.8-rc1, not 4.7.

thanks,

greg k-h