Re: [PATCH] thermal: rcar_thermal: don't call thermal_zone_device_unregister when USE_OF_THERMAL
From: Zhang Rui
Date: Mon Aug 22 2016 - 03:53:03 EST
On ä, 2016-08-22 at 03:19 +0000, Kuninori Morimoto wrote:
> From: Bui Duc Phuc <bd-phuc@xxxxxxxxxxx>
>
> devm_thermal_zone_of_sensor_register() case doesn't need to call
> thermal_zone_device_unregister().
> Otherwise, rcar-thermal can't register thermal zone again after
> rebind.
> This patch fixes it.
>
> Signed-off-by: Bui Duc Phuc <bd-phuc@xxxxxxxxxxx>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
Patch applied.
thanks,
rui
> ---
> Âdrivers/thermal/rcar_thermal.c | 3 ++-
> Â1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/rcar_thermal.c
> b/drivers/thermal/rcar_thermal.c
> index 4d07644..b5c6442 100644
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -419,9 +419,10 @@ static int rcar_thermal_remove(struct
> platform_device *pdev)
> Â
> Â rcar_thermal_for_each_priv(priv, common) {
> Â rcar_thermal_irq_disable(priv);
> - thermal_zone_device_unregister(priv->zone);
> Â if (rcar_use_of_thermal(dev))
> Â thermal_remove_hwmon_sysfs(priv->zone);
> + else
> + thermal_zone_device_unregister(priv->zone);
> Â }
> Â
> Â pm_runtime_put(dev);