Re: [PATCH 1/2] drivercore: Add helper macro for misc device boilerplate
From: kbuild test robot
Date: Mon Aug 22 2016 - 04:51:45 EST
Hi PrasannaKumar,
[auto build test ERROR on linus/master]
[also build test ERROR on v4.8-rc3 next-20160822]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]
url: https://github.com/0day-ci/linux/commits/PrasannaKumar-Muralidharan/drivercore-Add-helper-macro-for-misc-device-boilerplate/20160821-151236
config: s390-allyesconfig (attached as .config)
compiler: s390x-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=s390
All error/warnings (new ones prefixed by >>):
In file included from drivers/s390/char/sclp_ctl.c:11:0:
>> include/linux/miscdevice.h:78:2: warning: data definition has no type or storage class
module_driver(__misc_device, misc_register, misc_deregister)
^
>> drivers/s390/char/sclp_ctl.c:129:1: note: in expansion of macro 'module_misc_device'
module_misc_device(sclp_ctl_device);
^
>> include/linux/miscdevice.h:78:2: error: type defaults to 'int' in declaration of 'module_driver' [-Werror=implicit-int]
module_driver(__misc_device, misc_register, misc_deregister)
^
>> drivers/s390/char/sclp_ctl.c:129:1: note: in expansion of macro 'module_misc_device'
module_misc_device(sclp_ctl_device);
^
>> drivers/s390/char/sclp_ctl.c:129:1: warning: parameter names (without types) in function declaration
>> drivers/s390/char/sclp_ctl.c:124:26: warning: 'sclp_ctl_device' defined but not used [-Wunused-variable]
static struct miscdevice sclp_ctl_device = {
^
cc1: some warnings being treated as errors
vim +78 include/linux/miscdevice.h
72
73 /*
74 * Helper macro for drivers that don't do anything special in module init / exit
75 * call. This helps in eleminating of boilerplate code.
76 */
77 #define module_misc_device(__misc_device) \
> 78 module_driver(__misc_device, misc_register, misc_deregister)
79
80 #define MODULE_ALIAS_MISCDEV(minor) \
81 MODULE_ALIAS("char-major-" __stringify(MISC_MAJOR) \
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: Binary data