Re: [PATCH v1 1/1] Revert "tty/serial/8250: use mctrl_gpio helpers"

[Heikki Krogerus]

Hi,

On Tue, Aug 16, 2016 at 03:06:54PM +0300, Andy Shevchenko wrote:
> Serial console is broken in v4.8-rcX. Mika and I independently bisected down to
> commit 4ef03d328769 ("tty/serial/8250: use mctrl_gpio helpers").
> 
> Since neither author nor anyone else didn't propose a solution we better revert
> it for now.
> 
> This reverts commit 4ef03d328769eddbfeca1f1c958fdb181a69c341.

Maybe you should have explained the problem in the commit message.

I just hit the issue, and can confirm that this patch fixes it. So
basically 8250 is broken in v4.8. Shouldn't this have "Cc: stable.."
tag?

> Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> Link: https://lkml.kernel.org/r/20160809130229.GN1729@xxxxxxxxxxxxxxxxxx
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

In any case, FWIW:

Tested-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>


Thanks,

-- 
heikki