Re: [PATCH v1 02/10] documentation: Add scheduler/sched-avg.txt

From: Randy Dunlap
Date: Mon Aug 22 2016 - 12:50:36 EST


On 08/09/16 17:14, Yuyang Du wrote:
> This doc file has the program to generate the constants to compute
> sched averages.
>
> Signed-off-by: Yuyang Du <yuyang.du@xxxxxxxxx>
> ---
> Documentation/scheduler/sched-avg.txt | 94 +++++++++++++++++++++++++++++++++
> 1 file changed, 94 insertions(+)
> create mode 100644 Documentation/scheduler/sched-avg.txt

I'll confirm that it builds and generates a buildable source file
as long as "u32" is understood (defined/typedef'd).

I would rather see it in tools/ as a C source file with comments as
follows:

// The following program is used to generate the constants for
// computing sched averages.

// C program (compile with -lm)

> +#include <math.h>
> +#include <stdio.h>

Maybe even add
#include <stdint.h>

and
typedef uint32_t u32;


thanks,
--
~Randy