Re: [PATCH 4/9] regulator: axp20x: support AXP806 variant
From: Mark Brown
Date: Mon Aug 22 2016 - 12:53:24 EST
On Sun, Aug 21, 2016 at 10:11:20AM +0800, Chen-Yu Tsai wrote:
> + if (id == AXP806_DCDCB) {
> + return (((reg & GENMASK(7, 6)) == BIT(6)) ||
> + ((reg & GENMASK(7, 6)) == BIT(7)));
> + } else if (id == AXP806_DCDCC) {
> + return ((reg & GENMASK(7, 6)) == BIT(7));
> + } else if (id == AXP806_DCDCE) {
> + return !!(reg & BIT(5));
> + }
This looks like you're trying to write a switch statement, please do
that.
Attachment:
signature.asc
Description: PGP signature