Re: [PATCH] acpi, nfit: check for the correct event code in notifications

From: Dan Williams
Date: Mon Aug 22 2016 - 18:43:29 EST


On Fri, Aug 19, 2016 at 1:40 PM, Vishal Verma <vishal.l.verma@xxxxxxxxx> wrote:
> Commit 209851649dc4 "acpi: nfit: Add support for hot-add" added
> support for _FIT notifications, but it neglected to verify the
> notification event code matches the one in the ACPI spec for
> "NFIT Update". Currently there is only one code in the spec, but
> once additional codes are added, older kernels (without this fix)
> will misbehave by assuming all event notifications are for an
> NFIT Update.
>
> Fixes: 209851649dc4 ("acpi: nfit: Add support for hot-add")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Cc: <linux-acpi@xxxxxxxxxxxxxxx>
> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
> Reported-by: Linda Knippers <linda.knippers@xxxxxxx>
> Signed-off-by: Vishal Verma <vishal.l.verma@xxxxxxxxx>

Looks good to me. Given the lead time of spec changes I think this
can wait for the 4.9 merge window. I'll add it to the -next branch.